search

ember-cli / ember-ajax

Service for making AJAX requests in Ember applications
MIT License
212 stars 87 forks source link

Resolve `ember-polyfills.deprecate-assign` deprecation warnings #463

Closed boris-petrov closed 2 years ago

boris-petrov commented 2 years ago

Because the latter is deprecated in Ember 4.

cc @Turbo87

boris-petrov commented 2 years ago

Ping @Turbo87. :)

boris-petrov commented 2 years ago

Ping @Turbo87. :)

Turbo87 commented 2 years ago

I'm no longer on the ember-cli team, I'm not maintaining this addon and I'm not even using it anymore. Feel free to ping the ember-cli team though 🤷‍♂️

rmachielse commented 2 years ago

@mike-north @rwjblue anyone who can merge/release this trivial change?

bertdeblock commented 2 years ago

Updated the PR to use the spread syntax for /addon code, so we don't have to do a major.

bertdeblock commented 2 years ago

Published as v5.1.2. Thanks for doing the work @boris-petrov.

boris-petrov commented 2 years ago

Thank you for taking it all the way to a release!