ember-cli / ember-ajax

Service for making AJAX requests in Ember applications
MIT License
212 stars 87 forks source link

Does this addon work with ember octane versions ? #467

Open SandeepJoel opened 2 years ago

SandeepJoel commented 2 years ago

Got the error "Could not find module jquery imported from ember-ajax/utils/ajax" while executing the below function call.

return this.ajax
.request('/api/token', {
  method: 'POST',
  // url: '/api/token',
  data: payloadData,
})
.then((result) => {
  return result.token;
})
.catch(function (error) {
  console.log('Api failure', error);
});

Doing ember install @ember/jquery seems to fix this issue. Why is this fix needed ?

webark commented 2 years ago

do you really want to know..? 🥴

SandeepJoel commented 2 years ago

Atleast have we documented this somewhere in this repo ?

webark commented 2 years ago

https://github.com/ember-cli/ember-ajax/blob/5520bdf3561175f0a6b5827cd0c2d4b36dd2ef4f/addon/utils/ajax.ts#L1-L6

you can see here that it's just importing jquery to use as its ajax method.

Don't think it's documented anymore. There's an ember-ajax-fetch which has a very similar api but uses fetch.