ember-cli / ember-cli-babel-polyfills

Split-build polyfills for evergreen and legacy browsers
MIT License
34 stars 6 forks source link

Migrate from @babel/polyfill #8

Closed Exelord closed 5 years ago

Exelord commented 5 years ago

Fix: #7

It uses core-js and runtime-regenerator directly instead of using deprecated @babel/polyfill as suggested in the migration guide.

I tested the build files and polyfills on legacy browsers and looks like it works correctly :)

Exelord commented 5 years ago

@pzuraq any feedback?

Exelord commented 5 years ago

Hmm I didn't test it with babel 6. But I guess it will work in the same way. The difference is only with preset env location and this has not been changed.

Sure If you can, that would be cool to test it.

pzuraq commented 5 years ago

Thanks for getting this started!

pzuraq commented 5 years ago

Released in v2.0.0

Exelord commented 5 years ago

Whoops... I notice some unexpected error after upgrade to v2 :/

Build Error (broccoli-persistent-filter:TransformAmd) in output/chunk1.js

ember-cli-babel-polyfills: unable to remap: chunk1.js

at TransformAmd.processString (ember-cli-babel-polyfills/lib/transform-amd.js:25:13)