search

ember-cli / ember-cli-clean-css

CSS minification via clean-css for Ember CLI
MIT License
6 stars 7 forks source link

v1.x of this addon produces invalid/broken CSS in production builds #297

Open runspired opened 2 years ago

runspired commented 2 years ago

It also doesn't have a clear way to configure it, and even its existence and utilization by the build is hard to learn about.

Related issue: https://github.com/adopted-ember-addons/ember-cli-sass/issues/231

Discord discussion: https://discord.com/channels/480462759797063690/486013244667068436/972196025479593994

Ember Blog refactoring due to bugs this introduces: https://github.com/ember-learn/ember-website/issues/807#issuecomment-824705786

cc @nickschot @acorncom

acorncom commented 2 years ago

See also https://github.com/ember-cli/ember-cli-clean-css/pull/278 and https://github.com/ember-cli/ember-cli/issues/8457 for additional backstory

kategengler commented 1 year ago

v2.0 of this addon downgraded clean-css to the version used in existing Ember apps, so with that version, this should no longer be true. I am leaving this issue open so that we remember to test this when we do put out a version with a newer clean-css.