search

ember-cli / ember-cli-deprecation-workflow

MIT License
165 stars 43 forks source link

`deprecationWorkflow` does not exist? #100

Open mydea opened 3 years ago

mydea commented 3 years ago

I just tried installing the 2.0.0-beta.2, and run deprecationWorkflow.flushDeprecations() as the readme says, but it complains that deprecationWorkflow is not defined for me?

mydea commented 3 years ago

I digged into it a bit, and it seems that in my (fairly normal, up to date Octane) app this line:

https://github.com/mixonic/ember-cli-deprecation-workflow/blob/cb87969bc55c45c9ca042ab9ab2ee7428c4dfb8d/index.js#L26

always returns false, because we have tests disabled by default to speed up the dev build. Wouldn't it make sense to check if env === "development" (maybe in addition)?

nlfurniss commented 3 years ago

Seeing the same issue with 2.0.0