search

ember-cli / ember-cli-deprecation-workflow

MIT License
165 stars 43 forks source link

Ship 2.0 #109

Closed mixonic closed 3 years ago

mixonic commented 3 years ago

This issue tracks work blocking the release of a final 2.0 release.

ember-cli-deprecation-workflow 2.0 will introduce the following breaking changes:

TODO:

See also https://github.com/mixonic/ember-cli-deprecation-workflow/labels/2.0

chancancode commented 3 years ago

Probably a good opportunity to drop Node 10 as well?

mixonic commented 3 years ago

I would like to support old versions of Ember, as the point of this library is to help complex/large apps upgrade and there are many not on 3.16.

However I have no problem requiring Ember CLI 3.16+ and something newer than Node 10. The addon isn't helping upgrade those things, apps can upgrade them independently of Ember and should.

chancancode commented 3 years ago

Yeah I think that’s consistent with the support policies. Since node 10 is EOL, if we don’t drop it now we are going to have issues when other deps start dropping node 10, especially when not all of them bump major when doing so.

rwjblue commented 3 years ago

Ya, let’s make node engines 12.* || >= 14 (dropping 10 and 13, both of which are EOL).

gilest commented 3 years ago

This can be closed, yes?

mixonic commented 3 years ago

🎉 Yep!