search

ember-cli / ember-cli-deprecation-workflow

MIT License
165 stars 43 forks source link

[BUGFIX] Check the incremented count for limit #123

Closed mixonic closed 3 years ago

mixonic commented 3 years ago

The prior implementation was checking count without incrementing it, and the implementation which wanted to log the limit message on the 100th message was logging it on the 101st. Additionally, the check for presence of the option.id was not correct.

Extracted from https://github.com/mixonic/ember-cli-deprecation-workflow/pull/118

mixonic commented 3 years ago

cc @wagenet this cleans up some misses from the implementation in https://github.com/mixonic/ember-cli-deprecation-workflow/pull/93

wagenet commented 3 years ago

Thanks!