search

ember-cli / ember-cli-deprecation-workflow

MIT License
165 stars 43 forks source link

[possible bug]: `TypeError: require.has is not a function` #128

Closed foxtree closed 2 years ago

foxtree commented 3 years ago

Hi, I am attempting to upgrade an ember app from 3.20 to 3.24, and trying to use this addon to suppress deprecation logging that causes the ember test process to hang.

However, after installing and configuring this addon, running ember test fails with several errors, including: image

This appears to be due to the following line in vendor/ember-cli-deprecation-workflow/main.js

^these errors do not occur when I install and configure ember-cli-deprecation-workflow@v2.0.0-beta.4

...Is this a bug with version 2.0?

kategengler commented 3 years ago

I'm seeing this just now after adding ember-cli-deprecation-workflow@2.0.0 to an existing app already on Ember v3.24. Seen when running ember s and going to the main page of the app.

kategengler commented 3 years ago

ember-classic-decorator seems to be the problem https://github.com/emberjs/ember-classic-decorator/issues/74

foxtree commented 3 years ago

Thanks for replying.

I was able to get ember-cli-deprecation-workflow@^1.0.1 to work with this particular project, so we'll be holding of on version 2, for now.

elwayman02 commented 3 years ago

I'm also seeing this error in an open-source project. Here's a failing PR that reproduces it just by bumping this package to 2.0.0:

https://github.com/elwayman02/ember-scroll-modifiers/pull/407/files

We get ember-classic-decorator through ember-cli-addon-docs, so it's likely the same issue noted by @kategengler above.

elwayman02 commented 3 years ago

Fix is here, potentially: https://github.com/emberjs/ember-classic-decorator/releases/tag/v2.0.1

snewcomer commented 3 years ago

This can be closed. Verified!