search

ember-cli / ember-cli-deprecation-workflow

MIT License
165 stars 43 forks source link

id: ember-global deprecation is not silenced #134

Open snewcomer opened 2 years ago

snewcomer commented 2 years ago

This seems like a timing issue in tests. Have both of these in the config file.

        { handler: 'silence', matchId: 'ember-global' }, 
        { handler: 'silence', matchMessage: /Usage of the Ember Global is deprecated/ },

Screen Shot 2021-11-11 at 11 31 28 AM

mixonic commented 2 years ago

I'm not sure this is enough to trivially reproduce the issue. There isn't anything special about the global deprecation matcher. It should be easy to triage in your application if the deprecation handler code path is being hit at all.

Gaurav0 commented 2 years ago

It seems all of the deprecation messages generated here, which we can collectively refer to as "build time deprecations", aren't silenced / thrown if referenced in the deprecation workflow file.

https://github.com/emberjs/ember.js/blob/master/lib/index.js#L66-L134