search

ember-cli / ember-cli-deprecation-workflow

MIT License
165 stars 43 forks source link

Update @ember/string to v4 #194

Closed SergeAstapov closed 2 months ago

SergeAstapov commented 4 months ago

This dedupes dependencies in node_modules.

however, couldn't find where it actually is being used, so wonder if we can remove this from dependencies?

NullVoxPopuli commented 2 months ago

I just ran in to this when trying to upgrade @ember/string 🤔 I also could not find where it is used

NullVoxPopuli commented 2 months ago

looks like it has something to do with embroider's implicit modules

NullVoxPopuli commented 2 months ago

Let's see what happens with CI: https://github.com/ember-cli/ember-cli-deprecation-workflow/pull/197