search

ember-cli / ember-cli-deprecation-workflow

MIT License
165 stars 43 forks source link

eslint conflict with ember-cli #50

Open jamesarosen opened 6 years ago

jamesarosen commented 6 years ago

By default, ember-cli adds the following to .eslintrc.js:

// node files
{
  env: {
    browser: false,
    node: true,
  },
  files: [
    'ember-cli-build.js',
    'testem.js',
    'blueprints/*/index.js',
    'config/**/*.js',
    'lib/*/index.js',
  ],
  parserOptions: {
    ecmaVersion: 2015,
    sourceType: 'script',
  },
},

That means the output to be copied to config/deprecation-workflow.js should have something like

/* eslint-env browser */

or

/* globals window */

at the top.

Or, alternatively, ember-cli-deprecation-workflow should add

excludedFiles: [ 'config/deprecation-workflow.js' ],

to the relevant overrides section.

mixonic commented 2 years ago

I think this implies that workflow creates the file on installation, which it could. It doesn't today.