Raising a deprecation warning when included in modern Ember app (ironically)

ember-cli / ember-cli-deprecation-workflow

MIT License

165 stars 43 forks source link

Raising a deprecation warning when included in modern Ember app (ironically) #51

Closed lukemelia closed 6 years ago

lukemelia commented 6 years ago

When booting up an Ember 3.x app that depends on this addon, the following deprecation warning is emitted:

DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: [appname] -> ember-cli-deprecation-workflow -> ember-cli-babel

I looked into upgrading this addon, but it is unclear to me how monkey-patching deprecate would work with the new modules-based API.

rwjblue commented 6 years ago

I tried to do a basic round of updating in https://github.com/mixonic/ember-cli-deprecation-workflow/pull/47, but ran out of time and now it has languished 😢.

rwjblue commented 6 years ago

Though I'm not really sure why this addon would issue a deprecation, as we don't have ember-cli-babel as a dependency (its only a dev dep)...

rwjblue commented 6 years ago

Ahh it was fixed in https://github.com/mixonic/ember-cli-deprecation-workflow/pull/46 and released as 0.2.4.

@lukemelia - Can you confirm updating to latest fixes that deprecation?

rwjblue commented 6 years ago

Closing (I believe this was addressed in #46)...