search

ember-cli / ember-cli-deprecation-workflow

MIT License
165 stars 43 forks source link

Limit logging #93

Closed wagenet closed 3 years ago

wagenet commented 3 years ago

Limits console log to avoid causing ember server to hang which can happen if there is too much logging.

wagenet commented 3 years ago

@mixonic can we get this merged?

boris-petrov commented 3 years ago

@wagenet - perhaps make the log limit configurable?

wagenet commented 3 years ago

@boris-petrov I'm not opposed to that, but I also don't see it being a necessity either. 100 should be far more than enough and resolve the problem of the runner hanging due to thousands of messages.

boris-petrov commented 3 years ago

Exactly - 100 may be much more than someone's preference. :)

wagenet commented 3 years ago

Yeah, my concern was less about preference and more about making sure the runner doesn't crash!

mixonic commented 3 years ago

I've rebased this on master to pick up https://github.com/mixonic/ember-cli-deprecation-workflow/pull/111 which I expect brings us a green test suite.

I suspect this is behavior we would like Ember itself to provide if effect of too much logging is "testem crashes". That doesn't block landing it here though!

Thanks @wagenet