ember-cli / ember-cli-htmlbars

MIT License
77 stars 66 forks source link

chore: replace json-stable-stringify with safe-stable-stringify #738

Open BridgeAR opened 2 years ago

BridgeAR commented 2 years ago

This is a performance improvement as the latter is actually faster.

json-stable-stringify x 13,870 ops/sec ±0.72% (94 runs sampled) safe-stable-stringify x 30,367 ops/sec ±0.39% (96 runs sampled)

The only difference is that objects with circular reference are from now on also accepted instead of throwing an error.

rwjblue commented 2 years ago

Hmm, not sure why CI didn't run. Merging master here again to see if that kicks things off.