search

ember-cli / ember-cli-htmlbars

MIT License
77 stars 66 forks source link

Avoid registering `babel-plugin-ember-template-compilation` repeatedly #747

Closed dfreeman closed 2 years ago

dfreeman commented 2 years ago

I'm looking at upgrading an app to Ember 3.28, and am running into issues where babel-plugin-ember-template-compilation is being registered multiple times.

It looks like the isInlinePrecompileBabelPluginRegistered utility function here is meant to act as a generic "have we already installed our plugin" guard, but it wasn't updated when the new Babel plugin was introduced for the post-modules-polyfill world.

Based on @nightire's comment on https://github.com/ember-cli/ember-cli-htmlbars/issues/297#issuecomment-1101970035, I wonder if this might be what they're running into as well? Our app also has ember-engines as a dependency, and I've confirmed locally that this change eliminates the "duplicate Babel plugin" error I was seeing.

dfreeman commented 2 years ago

@rwjblue any chance you'll have time this week to give this one a look? Not the end of the world if not, just planning 🙂