ember-cli / ember-cli-htmlbars

MIT License
77 stars 66 forks source link

Template compilation broken on ember-cli < 3.13 in addons #754

Closed ef4 closed 2 years ago

ef4 commented 2 years ago

The changes introduces in ember-cli-htmlbars 6.1 may have broken support for ember-cli < 3.13 when used in addons. This was first noticed by @mansona in https://github.com/ef4/ember-auto-import/pull/533

In that situation it looks like templates in addons don't go through babel after going through the template preprocessor, so they end up with untranspiled use of import { hbs } from 'ember-cli-htmlbars'.

The test suite here unfortunately doesn't really exercise any non-default ember-cli versions and doesn't include end-to-end testing of an addon's templates.

While these are super old versions to support, ember-cli-htmlbars 6 is supposed to work down to ember 3.8.