search

ember-cli / ember-cli-htmlbars

MIT License
77 stars 66 forks source link

Code coverage off by 2 lines in components with co-located template #779

Open robinborst95 opened 11 months ago

robinborst95 commented 11 months ago

In components with a co-located template, the plugin adds import { hbs } and const __COLOCATED_TEMPLATE__ = ... to the source file, and that is affecting the code coverage. Not only does this affect the percentage itself, as const __COLOCATED_TEMPLATE__ = ... is seen as a line that is covered without it being part of the source code, it also makes it very difficult to look at a coverage report as the lines are off by 2 (see screenshot)

In https://github.com/ember-cli/ember-cli-htmlbars/pull/558 and https://github.com/ember-cli/ember-cli-htmlbars/pull/763, something similar is addressed, but then just for source maps which appeared to be resolved without the fixes. However, for the code coverage this is still relevant, and placing the lines at the end would at least solve the off-by-2 issues (would have been fun if it was the typical off-by-1 error :smile:)

image

wagenet commented 10 months ago

Code coverage tools generally use the source maps as well, so fixing those should resolve the coverage issues. Indeed, that's my primary motivation to fix this.