search

ember-cli / ember-cli-update

Update Ember CLI projects
MIT License
277 stars 40 forks source link

--to flag still prompting for user interaction #1148

Open elwayman02 opened 3 years ago

elwayman02 commented 3 years ago

When we run a command using the --to flag (e.g. ember-cli-update --to 3.26.1), the output still prompts to ask which version we want:

? Blueprint updates have been found. Which one would you like to update? addon,
current: 3.20.0, latest: 3.27.0

Hitting enter a couple times moves past this prompt and produces the expected behavior (that is, it updates to the target version and not, say, latest), but I would expect that providing the --to option for ember-cli-update would preempt the need to ask the user this question. This becomes particularly important when attempting to use ember-cli-update as a codemod across multiple projects at the same time, or via an automated job. We want to be able to provide all the necessary information when the command is invoked, so that no process gets blocked on waiting for interaction with a user prompt.

Timbuktu1982 commented 2 years ago

Hey. In the meantime, is there already a solution to the problem? THX

Timbuktu1982 commented 2 years ago

Hey. I have create a new fork with a fix for the problem. See https://github.com/Timbuktu1982/ember-cli-update...

elwayman02 commented 2 years ago

@Timbuktu1982 I'm sure if you open a PR for your fix, people would be happy to help review getting it into the main project!

Timbuktu1982 commented 2 years ago

Have done now...

pernambucano commented 1 year ago

Hi, now that we have a PR, do we need to do something to help merge it ?