After #1240, running ecu on a v2 addon gets further along, but it's still not quite right...
The v2 addon blueprint removed the name entry from its root level (monorepo) package.json. But as mentioned elsewhere this seems to cause ecu to run the blueprint with a fallback name of my-project instead of the actual addon's name, and that causes some weird diffs...
This is from running the master branch of ecu on ember-stargate, showing references to files in my-project being deleted by "us":
In the log you can see that it is running the blueprint with ember addon my-project ...:
Given that we have the right name not readily available in the root package.json anymore, we might want to grab it instead from config/ember-cli-update.json (by adding it there in a new version of the blueprint)?
Or (also) provide a CLI flag to specify it explicitly? (for when we don't have it anywhere, like with today's output of the v2 blueprint)
After #1240, running ecu on a v2 addon gets further along, but it's still not quite right...
The v2 addon blueprint removed the
nameentry from its root level (monorepo)package.json. But as mentioned elsewhere this seems to cause ecu to run the blueprint with a fallback name ofmy-projectinstead of the actual addon's name, and that causes some weird diffs...This is from running the master branch of ecu on ember-stargate, showing references to files in
my-projectbeing deleted by "us":In the log you can see that it is running the blueprint with
ember addon my-project ...:Given that we have the right name not readily available in the root
package.jsonanymore, we might want to grab it instead fromconfig/ember-cli-update.json(by adding it there in a new version of the blueprint)?Or (also) provide a CLI flag to specify it explicitly? (for when we don't have it anywhere, like with today's output of the v2 blueprint)
cc @mansona