search

ember-cli / ember-cli

The Ember.js command line utility.
https://cli.emberjs.com
MIT License
3.26k stars 1.16k forks source link

Project#blueprintLookupPaths should account for `ember-blueprint` dependencies. #6952

Open rwjblue opened 7 years ago

rwjblue commented 7 years ago

Project.prototype.blueprintLookupPaths currently accounts for the blueprintPaths of all addons, in addition to the project's own blueprints. Unfortunately, this means it cannot resolve blueprints that are "stand alone blueprints" if they are dependencies of the project.

Stand alone blueprints (generally installed via git URL's or npm packages) use the ember-blueprint keyword (instead of ember-addon) to indicate they are not a full blown addon, but instead are a blueprint, this means they will not be included in Project.prototype.blueprintLookupPaths and therefore Blueprint.lookup will not find them even if the blueprint is a direct dependency of the project.

stefanpenner commented 7 years ago

In blrpnt I moved thenlookup stuff to a Load path passed in to blueprint. So the caller always decides. That approach should make it easier to addresss this problem

rwjblue commented 7 years ago

Shouldn't have been closed by that @glimmer/blueprint PR.

ro0gr commented 6 years ago

This issue was closed unintentionally again.

From glimmerjs/glimmer.js@8b95d66:

Ultimately, this commit should be able to be revertted once the upstream issue is resolved: ember-cli/ember-cli#6952.

locks commented 2 years ago

@rwjblue is this still relevant, or can it be closed?