search

ember-cli / ember-compatibility-helpers

Helpers that allow you to write backwards compat Ember addons
MIT License
24 stars 20 forks source link

More parallel build related fixes #23

Closed stefanpenner closed 5 years ago

stefanpenner commented 5 years ago

another one

pzuraq commented 5 years ago

Ah nevermind, I see it now. It resolves the path but not the actual plugin itself. Looks good!

pzuraq commented 5 years ago

I can’t release at the moment, but should be able to do it later tonight. Feel free to release in the meantime.

stefanpenner commented 5 years ago

The difference is, prior to this change we were providing a function as an argument to broccoli-babel-transpiler. Now we are providing a fully qualified path. A function is not serializable, but a string path is.

Broccoli-persistent-filter is smart enough to know, if it encounters a path in this position, it will simply require it, and utilize that require'd modules default export as the class it will instantiate.

More details: https://github.com/babel/broccoli-babel-transpiler#parallel-transpilation

stefanpenner commented 5 years ago

@pzuraq let me know when you have released, I am also unable to now.

edit: realized -> released (sorry about the typo)

pzuraq commented 5 years ago

Released in v1.0.2