Avoid duplicate plugin assertion.

[rwjblue]

This is a fairly rare issue, but when it does happen it is quite difficult to debug.

The specific setup is:

• addon A depends on ember-compatibility-helpers
• addon A has the following in its index.js:

module.exports = {
  name: require('./package').name,

  options: {
    m3: true,
    babel: {
      loose: true,
    },
  },
};

• addon B depends on addon A (not a dev dep)

In this scenario, addon A will be instantiated twice. Once for addon B's dummy app and again for addon B's direct dependency. Since addon A had a mutable object on its prototype (yes, you know whats coming now) ember-compatibility-helpers adds a plugins array to it and pushes into it. Even though it sets a local flag saying that _registeredWithBabel, that flag is per instance of ember-compatibility-helpers and in our scenario we actually have two instances (therefore making our check moot).

The fixes here, prevent adding our comparison and debug plugins twice by checking if they are already present before pushing (it also adds a name property, which helps as well).

[rwjblue]

FYI - I wanted to use ember-cli-babel-plugin-helpers to do this, but it does not work when you want to search for a specific name within the plugins array. I created https://github.com/dfreeman/ember-cli-babel-plugin-helpers/issues/5 to track that.

[rwjblue]

CI is getting trolled by:

• running in Node 6
• no lockfile
• someone has updated to async functions without a major version bump

[makepanic]

This fixes the issue for us when upgrading ember-data to 3.14 in a monorepo.

[pzuraq]

Let's bump to Node 8 and release a new major

[rwjblue]

👍

[omairvaiyani]

Fixed our issue, the culprit addon was @ember/ordered-set

[gabrielcsapo]

Is this something we can get merged? We are getting duplicate addons in our product.

[gabrielcsapo]

Looks like the async is coming from broccoli-rollup which is from ember-data

  - stack: /home/travis/build/pzuraq/ember-compatibility-helpers/node_modules/broccoli-rollup/dist/index.js:31
603    async build() {

=> Found "broccoli-rollup@2.1.1"
info Reasons this module exists
   - "ember-data" depends on it
   - Hoisted from "ember-data#broccoli-rollup"

[gabrielcsapo]

This might need to be rebased to get the CI fixes and rerun to get passing.

[rwjblue]

Rebased and pushed...

[rwjblue]

OK, finally green (thanks all).

@pzuraq - Mind merge + releasing (I'm on mobile)?