search

ember-cli / ember-compatibility-helpers

Helpers that allow you to write backwards compat Ember addons
MIT License
24 stars 20 forks source link

Allow to check for optional packages #38

Closed mydea closed 2 years ago

mydea commented 4 years ago

In the process of https://github.com/ember-cli/ember-fetch/pull/392, I learned that this addon throws an error at build time if trying to check for an addon that is not installed.

It would be nice to have an option to check for an optional package version!

rwjblue commented 4 years ago

Ya, agreed!

What do you think @pzuraq?

pzuraq commented 4 years ago

Yeah, I’m on board with that idea. Maybe a has method?

mydea commented 4 years ago

E.g. something like has(packageName, { min, max }) or something like this? To allow to also check for certain (optional) versions?

xg-wang commented 2 years ago

Closed by https://github.com/pzuraq/ember-compatibility-helpers/pull/54? @pzuraq @igorT

igorT commented 2 years ago

I believe so.

mydea commented 2 years ago

:+1: