search

ember-cli / ember-compatibility-helpers

Helpers that allow you to write backwards compat Ember addons
MIT License
24 stars 20 forks source link

Allow gte, lte used on optional package #42

Closed xg-wang closed 2 years ago

xg-wang commented 4 years ago

Previously this was always throwing an error when trying to compare a missing dependency at build time. There is no error handling provided anyway provided by this project, and detecting a missing dependency is better done at addon's build entry.

close https://github.com/pzuraq/ember-compatibility-helpers/issues/38

xg-wang commented 4 years ago

CI is currently broken on master

igorT commented 2 years ago

Master is green now, @pzuraq @xg-wang did we still want to do this? Seems useful to be able to check versions of optional dependencies.

xg-wang commented 2 years ago

I think this is still useful. @pzuraq can we re-run the checks? Let me know if there's anything else to chnage

pzuraq commented 2 years ago

Can you rebase the PR? It appears to be running on Travis still, which is a mess, but the main branch has transitioned to GH actions

igorT commented 2 years ago

I've rebased this, but couldn't push to the original branch, so opened a PR https://github.com/pzuraq/ember-compatibility-helpers/pull/54

igorT commented 2 years ago

This also needed a test fix, now #54 is green

xg-wang commented 2 years ago

Thanks guys!