search

ember-cli / ember-compatibility-helpers

Helpers that allow you to write backwards compat Ember addons
MIT License
24 stars 20 forks source link

[ci] fix ci by pinning dependencies to get node@6 to pass. #43

Closed gabrielcsapo closed 4 years ago

gabrielcsapo commented 4 years ago

Motivation

Getting #36 merged as a patch update.

gabrielcsapo commented 4 years ago

@pzuraq I tried for about 3 hours to figure out why the deps for node-7 tests weren't working. They work with the lock file in the repo but for some reason they aren't working with ember-try.

gabrielcsapo commented 4 years ago

This change always runs the node-7 tests before every matrix.

gabrielcsapo commented 4 years ago

Passing CI for node@6 and once we patch the duplicate addons we can bump everything to latest.

hjdivad commented 4 years ago

@gabrielcsapo thanks very much for digging into this; it would be great to get the CI cleaned up here.

On the specific approach though, I don't think we want to pin deps. I expect the right to do is to update CI to run node@10 and cut a major that drops support for everything prior to 10.

@rwjblue @pzuraq thoughts?

pzuraq commented 4 years ago

I agree that we want to do this in general, but I’m also ok with merging and releasing a patch release as a bugfix for the last version of v1

pzuraq commented 4 years ago

I also think this is fine since we're just pinning devDeps for tests, we aren't making any other meaningful changes to the code. Merged to unblock the other PR, @gabrielcsapo like I said before I think either path forward here is ok, happy to merge a bugfix and release as a patch, but also equally happy to remove support for Babel 6 and Node < current LTS, and release a new major. I do think that the later solution would be better and would prefer it, but I don't have the time at the moment to take it on.