ember-cli / ember-compatibility-helpers

Helpers that allow you to write backwards compat Ember addons
MIT License
24 stars 20 forks source link

Ensure `gte` &co invalidate properly when dependencies change #55

Closed brendenpalmer closed 2 years ago

brendenpalmer commented 2 years ago

This adds an additional property, cacheKey, to the options hash so that this is invalidated on subsequent builds if the lockfile changes. Specifically so that this is included as part of the cache key generation here: https://github.com/babel/broccoli-babel-transpiler/blob/master/index.js#L85. The current cache behavior isn't enough; it's possible for us to use a previously cached version as part of this plugin even if yarn.lock/node_modules changes, which can break the expectation at runtime.