search

ember-cli / ember-fetch

HTML5 fetch polyfill from github wrapped and bundled for ember-cli users.
MIT License
176 stars 82 forks source link

Rename import path to 'ember-fetch' #737

Closed lflo5727 closed 11 months ago

lflo5727 commented 11 months ago

As per this issue: https://github.com/ember-cli/ember-fetch/issues/330 ember-fetch is incompatible with v2 addons and still required for some Ember projects.

This fixes the issue with v2 addons and follows more direct naming conventions. I also removed the TS portion from the README as that workaround is no longer needed now that the module name matches the import name.

lflo5727 commented 11 months ago

It looks like the CI tests are using too new of a version of Node for this project. They are on 18 and the project needs 14 at newest it seems

NullVoxPopuli commented 11 months ago

They are on 18 and the project needs 14 at newest it seems

would you be willing to help out with some infra updates? I've made a to-do list here: https://github.com/ember-cli/ember-fetch/issues/738

We can target the next branch so if anything needs to happen with master we aren't getting in the way

lflo5727 commented 11 months ago

They are on 18 and the project needs 14 at newest it seems

would you be willing to help out with some infra updates? I've made a to-do list here: #738

Anything in particular? Should we make this a v2 addon here? Our project I'm wanting to use this for is still stuck on v3 of Ember at the moment, so not super keen on dropping support for everything < 4 in this work.

NullVoxPopuli commented 11 months ago

Anything in particular? Should we make this a v2 addon here?

imo, all of it needs to be done, including v2 conversion (which is probably ~ 99% tests, and 1% actual code)

so not super keen on dropping support for everything < 4 in this work.

we'd only really be dropping IE11, I've updated #738 to call that out specifically