search

ember-cli / ember-load-initializers

MIT License
14 stars 37 forks source link

Convert to V2 addon #303

Open bwbuchanan opened 2 years ago

bwbuchanan commented 2 years ago

This is an attempt at converting ember-load-initializers to the v2 addon format. Feedback welcomed.

SergeAstapov commented 2 years ago

@bwbuchanan would you like to incorporate recommendations from https://github.com/embroider-build/embroider/blob/main/PORTING-ADDONS-TO-V2.md?

NullVoxPopuli commented 10 months ago

@SergeAstapov is this something we should take over? :sweat_smile:

chancancode commented 10 months ago

I suppose it doesn’t hurt, but does it really matter that this is v1 or v2 when the core thing that this addon does is iterating over require.entries to look for the initializers? Shouldn’t this functionality be implemented in embroider natively and make this addon unnecessary/no-op under embroider?

SergeAstapov commented 10 months ago

@SergeAstapov is this something we should take over? 😅

@NullVoxPopuli I'd love gets this over the finish line! although this would fall somewhere in the queue of addons I do have maintainer access. I can seek help of co-workers to get this over the finish line. We just need someone who can land PRs and do the release.

I suppose it doesn’t hurt, but does it really matter that this is v1 or v2 when the core thing that this addon does is iterating over require.entries to look for the initializers?

@chancancode as this point in time, the main problem with this addon is the fact that it depends on ember-cli-typescript@2, which is problematic per https://github.com/ember-cli/ember-load-initializers/issues/291#issuecomment-1285358767. So at least maintenance like bumping that to v5 is overdue, which kinda brings a question if we should do one step over and convert to v2 which is not that hard then.

Shouldn’t this functionality be implemented in embroider natively and make this addon unnecessary/no-op under embroider?

TBH it always was a mystery to me why this addon even exists (maybe was a part of migration story from ember-app-kit to Ember CLI?). having this baked into Embroider IMO sounds like a logical step long term.

chancancode commented 10 months ago

Yeah, if it's close and easy, like I said, I don't think it hurts to keep things up-to-date here. But personally, I think if this addon is still needed with Embroider/Polaris, then there is something deeply wrong. (Same deal as the fingerprinting stuff, etc.) So, personally, I think the priority should be making sure the functionality is implemented natively in Embroider.

ef4 commented 10 months ago

I think it's fine to make this change, and separately after we do https://github.com/emberjs/rfcs/blob/strict-es-module-support/text/0938-strict-es-module-support.md, use that to eliminate the dependence on requirejs.entries.