search

ember-cli / ember-page-title

Page title management for Ember.js Apps
https://ember-cli.github.io/ember-page-title/
Other
188 stars 57 forks source link

Fix release, beta and canary scenarios #259

Closed bertdeblock closed 1 year ago

bertdeblock commented 1 year ago

@knownasilya Don't think these changes should be labelled as breaking.

knownasilya commented 1 year ago

You did update the node version and some of the import paths, I think those are breaking. I might be wrong..

bertdeblock commented 1 year ago

I only updated the pinned Node version using Volta to make CI happy (I did not update engines). The other changes were only for the docs and test-app apps.

NullVoxPopuli commented 1 year ago

si, this is a browser-only v2 addon, so node version has no impact on consumers.