ember-cli / ember-page-title

Page title management for Ember.js Apps
https://ember-cli.github.io/ember-page-title/
Other
188 stars 57 forks source link

TypeScript conversion so we have accurately generated types for consumers #275

Closed NullVoxPopuli closed 9 months ago

NullVoxPopuli commented 9 months ago

These 3 PRs should be merged first:

As ember has first-class TypeScript support out of the box (almost), we need to to have all core addons also support that.

Like always, consumers don't need to use TypeScript, but our library code using TypeScript will provide better intellisense for both JavaScript and TypeScript users.

Incidentally, achieving more alignment with the TS-v2-addon blueprint, we gain support for Glint-using projects.

This work continues the work of https://github.com/ember-cli/ember-page-title/pull/246

Demo in the docs app: image

Changes:

NullVoxPopuli commented 9 months ago

Current issue with the embroider tests. image

what in tarnation is going on. broccoli doesn't go in the browser.