search

ember-cli / ember-template-imports

Template import support in Ember!
MIT License
74 stars 39 forks source link

add back toc names for inspector #241

Closed patricklx closed 1 month ago

patricklx commented 4 months ago

this was removed in v4

it was there until v3. https://github.com/ember-template-imports/ember-template-imports/blob/v3.4.2/src/babel-plugin.js#L42

with this change: image

lifeart commented 4 months ago

@patricklx I'm thinking about ways to integrate it to release pipeline to not miss it in future. We may add https://www.npmjs.com/package/babel-plugin-tester to test this babel plugin as part of test command Here is sample: https://github.com/babel-utils/babel-plugin-tester/tree/master/test/examples (tldr - we need to create folder with 3 files, input, output, babel config - and plugin will be executed over input and compared with output)

patricklx commented 1 month ago

@lifeart what about this?

lifeart commented 1 month ago

@patricklx looks good for me!

patricklx commented 1 month ago

Who can merge? @NullVoxPopuli ?

patricklx commented 1 month ago

Mostly it doesn't matter what path is in there. Here I'm also trying to fix the full path beeing added to the transform. That only happens under embroider.

For classic I'm depending in the project.root, parent.root to slice that off the filename.

NullVoxPopuli commented 1 month ago

Can you push again real quick? Ci was disabled