ember-cli / ember-try

An ember-cli addon to test against multiple npm dependencies, such as ember and ember-data.
MIT License
179 stars 58 forks source link

Remove warning about pnpm #956

Closed NullVoxPopuli closed 1 year ago

NullVoxPopuli commented 1 year ago

RFC: https://github.com/emberjs/rfcs/pull/907 Implementation PR: https://github.com/ember-cli/ember-cli/pull/10287 Advancement PR: https://github.com/emberjs/rfcs/pull/932

In this more involved CI setup, having the default pnpm flags https://github.com/NullVoxPopuli/ember-data-resources/actions/runs/5365368548/jobs/9734152943 and it also works

codecov[bot] commented 1 year ago

Codecov Report

Merging #956 (abdfb31) into master (81c6107) will increase coverage by 0.17%. The diff coverage is n/a.

:exclamation: Current head abdfb31 differs from pull request most recent head 3e1d4a2. Consider uploading reports for the commit 3e1d4a2 to get more accurate results

@@            Coverage Diff             @@
##           master     #956      +/-   ##
==========================================
+ Coverage   94.37%   94.54%   +0.17%     
==========================================
  Files          17       17              
  Lines         551      550       -1     
==========================================
  Hits          520      520              
+ Misses         31       30       -1     
Impacted Files Coverage Δ
lib/utils/dependency-manager-adapter-factory.js 91.30% <ø> (+3.80%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kategengler commented 1 year ago

Thank you!