search

ember-cli / ember-try

An ember-cli addon to test against multiple npm dependencies, such as ember and ember-data.
MIT License
180 stars 60 forks source link

Fix CI #959

Closed mansona closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #959 (1511826) into master (e060b86) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 1511826 differs from pull request most recent head e6b9e04. Consider uploading reports for the commit e6b9e04 to get more accurate results

@@           Coverage Diff           @@
##           master     #959   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files          17       17           
  Lines         550      550           
=======================================
  Hits          520      520           
  Misses         30       30
Impacted Files Coverage Δ
smoke-test-app/tests/dummy/config/ember-try.js 100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mansona commented 1 year ago

I was trying to extract this from #920 but actually it's a kinda pointless PR 🙈 we're starting to get npm peer dependency issues in that other PR because we have upgraded to a version that actually checks it. I am pushing the required changes to that PR directly 👍