search

ember-cli / ember-welcome-page

Welcome page for Ember CLI applications
MIT License
12 stars 23 forks source link

Convert to TS or supply ambient type definitions #387

Closed chriskrycho closed 1 year ago

chriskrycho commented 1 year ago

As part of Ember.js RFC #0800, this package needs to supply type definitions. Preferably, this would happen by converting to TS and generating from the source; as an alternative, it can publish ambient types (presumably starting with the ones on DefinitelyTyped).

All the members of the Typed Ember team are happy to advise on how to do this; feel free to reach out in #dev-typescript on Discord if you have questions!

ijlee2 commented 1 year ago

@chriskrycho and @ember-cli/ember-cli

I've completed the task. Can you review the project as a whole? Between now and Dec ~22nd~ 21st (I'm in CET), I can be available to clarify questions, fix bugs, and troubleshoot with releasing a new major version.

(I can also help in January next year so no rush.)