ember-cli / ember-welcome-page

Welcome page for Ember CLI applications
MIT License
12 stars 23 forks source link

Updated CI and dependencies. Dropped support for Node 12 and Ember 3.24 LTS. #388

Closed ijlee2 closed 1 year ago

ijlee2 commented 1 year ago

Description

As a part of https://github.com/emberjs/ember.js/issues/20162 and https://github.com/ember-cli/ember-welcome-page/issues/387, I will create a few pull requests to update this repo, so that we can ease future maintenance.

I made the following changes in this pull request:

References

bertdeblock commented 1 year ago

A bit late, but we can also added LTS 4.8 to the test scenario's?

ijlee2 commented 1 year ago

@bertdeblock Yep, I think adding 4.8 now is a good idea.

At the moment, I'm investigating why CI failed after merging the PR (seems to be an issue with dependencies). I'll get to both issues soon.

ijlee2 commented 1 year ago

The failed CI run seems to be related to a recent change in ember-qunit@v6.1.0.

https://github.com/emberjs/ember-qunit/pull/995/files#r1051368796