ember-cli / ember-welcome-page

Welcome page for Ember CLI applications
MIT License
12 stars 23 forks source link

Addressed failing CI. Added Ember 4.8 LTS to test matrix. #389

Closed ijlee2 closed 1 year ago

ijlee2 commented 1 year ago

Description

This pull request patches #388.

388 passed CI on December 16 (while in review status), but failed CI on the 17th (after merge). It turned out, ember-qunit released a minor version overnight and introduced a peer dependency requirement (@glimmer/interfaces@^0.84.2 and @glimmer/reference@^0.84.2).

To unblock work, I'll temporarily pin the version of ember-qunit to v6.0.0. (Yarn resolutions did not work, possibly because this project is not a yarn workspace yet.)

In the 3rd commit, I took @bertdeblock's suggestion and added Ember 4.8 LTS to the test matrix.

References