New rule: no-setupTest-from-ember-qunit

[rwjblue]

As of ember-cli@4.3.0 emberjs/rfcs#637 has been implemented in the new application blueprint.

Once an addon or application has migrated to using the new re-exports from tests/helpers/index.js they should no longer import them from the classic ember-qunit locations.

Rule details:

• Prevent importing setupTest, setupApplicationTest, and setupRenderingTest from the ember-qunit module
• Consider attempting to write a fixer that will add a new import from app-name/helpers instead.

Bad:

import { setupTest } from 'ember-qunit';
import { setupRenderingTest } from 'ember-qunit';
import { setupApplicationTest } from 'ember-qunit'

(all of these should be forbidden)

Good:

import { setupTest } from 'app-name/helpers';
import { setupRenderingTest } from 'app-name/helpers';
import { setupApplicationTest } from 'app-name/helpers';

[NullVoxPopuli]

• conditionally forbidden if there is a helpers file that contains those exports, ya?

[rwjblue]

yes, exactly