Plan v13 Release

[bmish]

Breaking changes:

• Rename recommended config to recommended-legacy, move flat config into exported configs object as recommended, remove string export for flat configs (per https://github.com/eslint/eslint/issues/18095#issuecomment-1951414598)
• Update Node support to ^18.18.0 || ^20.9.0 || >=21.1.0" to match ESLint

Previous release:

• v12: https://github.com/ember-cli/eslint-plugin-ember/releases/tag/v12.0.0 (https://github.com/ember-cli/eslint-plugin-ember/issues/1535)

[Techn1x]

We'll need eslint v9 support too. Currently I get this error

TypeError: context.getAncestors is not a function from this line https://github.com/ember-cli/eslint-plugin-ember/blob/7e6bca993226891be07ad367f066323573b672aa/lib/rules/require-return-from-computed.js#L69-L70

context.getAncestors() is replaced in v9 https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/#context.getancestors()

That's just the one I found, there is potentially other things that need to change for eslint v9

[bmish]

Can you file a separate issue for that? ESLint v9 support can be fixed in a bug fix release.

[Techn1x]

Can do, wasn't sure.

Will jump on that first thing tomorrow

[Techn1x]

https://github.com/ember-cli/eslint-plugin-ember/issues/2136

[LucasHill]

Fixed eslint v9 issues here: https://github.com/ember-cli/eslint-plugin-ember/pull/2153

[Windvis]

I think we should remove routes-segments-snake-case from the recommended set since the implicit route model hook has now been deprecated and that feature seemed to be the main motivation for this rule.