ember-cli / eslint-plugin-ember

An ESLint plugin that provides set of rules for Ember applications based on commonly known good practices.
MIT License
261 stars 202 forks source link

Fix nested classes case in `no-ember-super-in-es-classes` #2071

Closed CvX closed 7 months ago

CvX commented 8 months ago

This rule was incorrectly failing on the following code:

class Foo {
  bar() {
    Baz.reopen({
      quux() {
        this._super();
      },
    });
  }
}
CvX commented 8 months ago

Added a fix that checks for nested function bodies.

bmish commented 7 months ago

Thanks!