search

ember-cli / rfcs

Archive of RFCs for changes to ember-cli (for current RFC repo see https://github.com/emberjs/rfcs)
45 stars 54 forks source link

enhance `ember install` #107

Closed kellyselden closed 5 years ago

kellyselden commented 7 years ago

Rendered

webark commented 7 years ago

would there need to be a corresponding "remove/uninstall" then?

kellyselden commented 7 years ago

would there need to be a corresponding "remove/uninstall" then?

No. Since there is already an install command without an uninstall command, that seems out of scope.

buschtoens commented 7 years ago

Instead of erroring ember-cli should print a note, indicating to the user that the installed package is not an Ember add-on.

The package '${packageName}‘ is not an Ember add-on. In order to use it you'll probably need to perform some further custom setup.

webark commented 7 years ago

ya. with the motivation being that ember-cli chooses to use yarn for you.. if you just npm uninstall won't the reference stay in your yarn.lock? i guess it wouldn't actually install the package later.. but just seems a little messy, and that ideally you're still going to have to keep track if your using yarn or npm (same with when pulling a project for the first time)

kellyselden commented 7 years ago

@webark We already suffer from the problem that ember install package-name may modify your yarn.lock, but we have no ember uninstall package-name. Solving that would be the scope of a different RFC IMO.

Turbo87 commented 7 years ago

FWIW I'm not in favor of this RFC. ember install foobar serves the purpose of installing the dep and running the corresponding blueprint, but everything else can just be installed without ember-cli having to care about it. I think making ember install and alias for npm/yarn install increases the amount of perceived magic done by the Ember ecosystem.

Regarding ember install should work for non-addons: I thought that already worked without any issues. If it doesn't I would consider it a bug that should be fixed.

benkingcode commented 7 years ago

No. Since there is already an install command without an uninstall command, that seems out of scope.

I don't understand the reasoning behind this. If the goal is to make the use of npm or yarn 'invisible' to the end user, why would there not be a command to remove packages? It seems very unintuitive.

rwjblue commented 5 years ago

We are working on closing the ember-cli/rfcs repo in favor of using a single central RFC's repo for everything. This was laid out in https://emberjs.github.io/rfcs/0300-rfc-process-update.html.

Sorry for the troubles, but would you mind reviewing to see if this is still something we need, and if so migrating this over to emberjs/rfcs?

Thank you!