search

ember-cli / rfcs

Archive of RFCs for changes to ember-cli (for current RFC repo see https://github.com/emberjs/rfcs)
45 stars 54 forks source link

rfc to add liveReloadFilters property #71

Closed bantic closed 5 years ago

bantic commented 8 years ago

rendered

refs https://github.com/ember-cli/ember-cli/issues/6192

briangonzalez commented 7 years ago

@bantic Has any work begun on this one?

bantic commented 7 years ago

@briangonzalez Nope, no work done yet. I was hoping to get some more comments here and get a sense whether this would be ratified or needs more thought. Looks like you found a use case for this as well in https://github.com/dollarshaveclub/ember-cli/commit/a01de486a518276972596e534785cb80b7f1cc0a. Any thoughts on the RFC above?

briangonzalez commented 7 years ago

@bantic I read the whole thing over and I like the approach of keeping the old config around as to not break folks' current implementation.

Have you been able to take a peek at the code from https://github.com/dollarshaveclub/ember-cli/commit/a01de486a518276972596e534785cb80b7f1cc0a. We have it working for us locally, but I'd love others to give it a shot, too.

lukemelia commented 7 years ago

I could use this today. Your proposed solution seems reasonable to me @bantic. 👍

rwjblue commented 5 years ago

We are working on closing the ember-cli/rfcs repo in favor of using a single central RFC's repo for everything. This was laid out in https://emberjs.github.io/rfcs/0300-rfc-process-update.html.

Sorry for the troubles, but would you mind reviewing to see if this is still something we need, and if so migrating this over to emberjs/rfcs?

Thank you!