search

ember-cli / rfcs

Archive of RFCs for changes to ember-cli (for current RFC repo see https://github.com/emberjs/rfcs)
45 stars 54 forks source link

Configurable paths for Tree Paths #78

Closed jasonmit closed 7 years ago

jasonmit commented 7 years ago

Currently, all tree paths (app, tests, vendor, etc.) are static and cannot be configured.

I'd like to propose adding inputPaths to the EmberApp options hash allowing them to be optionally configured.

const app = new EmberApp(defaults, {
  inputPaths: {
    vendor: 'statics/vendor',
    public: 'statics/public',
    // etc..
  }
});

Unsure if this is a large enough change to warrant an RFC or not. Happy to PR this if it's something that has buy in.

rwjblue commented 7 years ago

Hmm. It surprises me that these are perceived as static. They should be already configurable via trees option.

rwjblue commented 7 years ago

https://github.com/ember-cli/ember-cli/blob/master/lib/broccoli/ember-app.js#L218-L251

jasonmit commented 7 years ago

Er, bad use of words.

I wasn't sure if this was a public API and it requires more intimate knowledge than I think most people are use to (returning broccoli trees versus providing paths).

jasonmit commented 7 years ago

I'm going to close this now, feel free to reopen if trees is private and I can do what is necessary to make it public (update docs or introduce inputPaths).

Thanks @rwjblue

nathanhammond commented 7 years ago

They're public enough that they won't change until we write ember-modules-app.