search

ember-cli / rfcs

Archive of RFCs for changes to ember-cli (for current RFC repo see https://github.com/emberjs/rfcs)
45 stars 54 forks source link

Support in-repo commands by default. #94

Closed rwjblue closed 5 years ago

rwjblue commented 7 years ago

Today, if you would like to add a command you must add an in-repo addon that implements the includedCommands method.

Contrast this with the ease of making a built-in blueprint: simply place a file in blueprints/some-name/index.js and 💥 everything works.

This issue is mostly to gauge interest in supporting auto-detection of project and addon commands by way of a specific location on disk (e.g. <project-root>/commands or <project-root>/lib/commands)...

👍 / 👎 ?

nathanhammond commented 7 years ago

Squatting on a folder is something I'm not a huge fan of, but this is a pretty common scenario and we have precedent. Consider this a mild :+1:.

kellyselden commented 7 years ago

Couldn't have said it better than @nathanhammond. Big yes to first class support. Bikeshedding on folder API necessary though IMO.

trentmwillis commented 7 years ago

I'm :+1: on this. Though, if we opt for a non-root folder, then we should likely consider updating the structure for blueprints as well (IMO).