search

ember-codemods / ember-angle-brackets-codemod

Codemod to convert curly braces syntax to angle brackets syntax
MIT License
60 stars 32 forks source link

Add `--telemetry` argument and ensure running without telemetry is possible #287

Closed rajasegar closed 4 years ago

rajasegar commented 4 years ago

Fixes #282

tylerturdenpants commented 4 years ago

Let' get this bad boy over to github actions. 😉LGTM. Thank you

tylerturdenpants commented 4 years ago

Oh one thing, should we have tests for the new command line options? Just a thought.

rajasegar commented 4 years ago

@tylerturdenpants Yes, definitely I will add tests for non-telemetry use case

rajasegar commented 4 years ago

@tylerturdenpants @Turbo87 @rwjblue Just a heads up, I have changed the logic here to make the tests passing, seem to have some doubts why it was working previously with telemetry and suddenly failing to work without telemetry. https://github.com/ember-codemods/ember-angle-brackets-codemod/blob/1bfbb5d9567fbdfe899736c929e61e29e81d5d6a/transforms/angle-brackets/transform.js#L335 The commit: https://github.com/ember-codemods/ember-angle-brackets-codemod/pull/287/commits/8e4fb8b8cade9e2309d4ea00d011aad8b27b0ca6#diff-0d3de8cb5f879d03639b6a16d0eddee0

tomwayson commented 4 years ago

This would fix #217 as well, right? If so, I'm a big fan.

rajasegar commented 4 years ago

Thanks @tomwayson @rwjblue for the review. Addressed the same in the latest commit.