ember-codemods / ember-angle-brackets-codemod

Codemod to convert curly braces syntax to angle brackets syntax
MIT License
60 stars 31 forks source link

Move helper disambiguation to a flag that is off by default #514

Closed mansona closed 4 months ago

mansona commented 5 months ago

With https://github.com/ember-codemods/ember-angle-brackets-codemod/pull/509 we introduced the ability to disambiguate helper calls by wrapping {{some-helper}} in round brackets like this {{(some-helper)}}. This helps in an embroider build but there is a bug somewhere in the stack with a classic build that causes this to fail at runtime.

We need to hide this functionality behind a flag so that people can opt-into it if it's something that they need/want i.e. if they are running embroider and wanting to turn on staticHelper and staticModifiers without turning on staticComponents 👍