search

ember-codemods / ember-module-migrator

Automated migration for new Ember application layout.
74 stars 15 forks source link

Route-specific components end up severely over-nested #39

Open chriskrycho opened 8 years ago

chriskrycho commented 8 years ago

We have a couple components that are only used on specific routes. It appears (I haven't dug into the migrator internals yet) that the intent is for route-specific components to live as children of the relevant routes. This makes good sense. However, the migrator (and perhaps the proposed pattern? Not sure) currently seems a bit... enthusiastic about the nesting (this is all under src/ui/routes):

nesting

It seems like the actual structure converted structure here should be something like this instead:

routes/
  checkout/
    place-order/
      -components/
        order-submission/
          olo-payment/
            olo-billing-scheme/
          create-card/

Obviously these can (and in several cases would) simply be moved to the general src/ui/components directory. My concern is just about all the extra checkout nesting.