search

ember-codemods / ember-module-migrator

Automated migration for new Ember application layout.
74 stars 15 forks source link

Imports rewrite for moved files #47

Closed andyhot closed 7 years ago

andyhot commented 7 years ago
andyhot commented 7 years ago

Tests only fail for node<=0.12 with SyntaxError: Use of const in strict mode. for code provided by jscodeshift. @rwjblue, do we still need to support that version range?

rwjblue commented 7 years ago

No, we should update .travis.yml to test 4,6,7,8 only.

andyhot commented 7 years ago

ok, done!

andyhot commented 7 years ago

I've just extended on the tests (please take a look again at the absolute/relative fixtures) and included the rest of the changes you suggested, thx!

andyhot commented 7 years ago

I've extended the test fixtures and resolved the relative test imports. I've not squashed the recent changes so that it's easier to see what has changed.

There's a pending todo in import-declarations.js for a refactoring that would minimize code complexity in that area but otherwise i believe the PR to be feature complete and hope ppl start testing it!

rwjblue commented 7 years ago

Thank you @andyhot!!

mixonic commented 7 years ago

Thank you @andyhot! Excellent work.