ember-codemods / ember-module-migrator

Automated migration for new Ember application layout.
74 stars 15 forks source link

Feature/config imports #49

Closed rwjblue closed 7 years ago

rwjblue commented 7 years ago

Made this PR from @andyhot's feature branch mentioned in https://github.com/rwjblue/ember-module-migrator/issues/48.

iezer commented 7 years ago

👍 On this, I just came across this use case. Thanks a lot @andyhot. I also found a a couple of similar cases where files have moved into src so the paths have to be updated:

There are examples in this commit

@andyhot do you have to time to add handlers for those files? If not I can try to find time later today.

andyhot commented 7 years ago

@iezer Can you augment the https://github.com/andyhot/ember-module-migrator/tree/feature/config-imports/test/fixtures/config (or perhaps https://github.com/rwjblue/ember-module-migrator/tree/master/test/fixtures/classic-relative-imports since what you're reporting doesn't seem relatedto the config handling) with some failures? Those imports from tests sources should have been working (since https://github.com/rwjblue/ember-module-migrator/commit/9db3d972a167404b4f27a9502395cb8c19909563) but i guess they need some finetuning

iezer commented 7 years ago

@andyhot Yep I'll write some tests for those cases.