ember-codemods / ember-module-migrator

Automated migration for new Ember application layout.
74 stars 15 forks source link

Pods Support + Classic/Pods Hybrid Support #57

Closed NullVoxPopuli closed 6 years ago

NullVoxPopuli commented 7 years ago

pods structure can now be migrated from.

This PR just adds to the existing code. I think a future PR should be a refactor. Lots of things need to be extracted to methods for easier inheritance.

rwjblue commented 7 years ago

This is looking really good! Thank you so much for working on it!

@mixonic / @andyhot - Mind reviewing also?

Subtletree commented 7 years ago

Looks like this currently wouldn't work for apps with no podModulePrefix or for any where podModulePrefix !== 'pods'. Is that right?

Have a decent sized app with mostly pods but some classic. Keen to help with testing if possible

andyhot commented 6 years ago

@rwjblue taking a look this weekend @Subtletree unless there's a regression (which judging from the passing tests there shouldn't) classic structure just works. If there's indeed a requirement for podModulePrefix to be 'pods', we'll fix that - i too have apps where that's not the case :)

NullVoxPopuli commented 6 years ago

how do you get access to the podModulePrefix?

NullVoxPopuli commented 6 years ago

so, here is my plan: I'm going to assume config/environment.js, and require/import that file, and get the podModulePrefix that way.

Is there any scenario where that wouldn't work?

NullVoxPopuli commented 6 years ago

Work on namespaceless pods: https://github.com/NullVoxPopuli/ember-module-migrator/pull/1

NullVoxPopuli commented 6 years ago

namespacelessness is gettitng there. I have a path to doing it, just need to work out some kinks

NullVoxPopuli commented 6 years ago

Node 4 had a syntax error????? SyntaxError: Unexpected token {

rwjblue commented 6 years ago

Probably destructuring

NullVoxPopuli commented 6 years ago

The failing tests are 'just' timeouts. :-\

NullVoxPopuli commented 6 years ago

@rwjblue squashed!

NullVoxPopuli commented 6 years ago

eslint check on node 7 timed out

rwjblue commented 6 years ago

restarted that one, but we should drop Node 7 in a followup PR