Closed NullVoxPopuli closed 6 years ago
This is looking really good! Thank you so much for working on it!
@mixonic / @andyhot - Mind reviewing also?
Looks like this currently wouldn't work for apps with no podModulePrefix
or for any where podModulePrefix
!== 'pods'. Is that right?
Have a decent sized app with mostly pods but some classic. Keen to help with testing if possible
@rwjblue taking a look this weekend @Subtletree unless there's a regression (which judging from the passing tests there shouldn't) classic structure just works. If there's indeed a requirement for podModulePrefix to be 'pods', we'll fix that - i too have apps where that's not the case :)
how do you get access to the podModulePrefix
?
so, here is my plan:
I'm going to assume config/environment.js
, and require/import that file, and get the podModulePrefix that way.
Is there any scenario where that wouldn't work?
Work on namespaceless pods: https://github.com/NullVoxPopuli/ember-module-migrator/pull/1
namespacelessness is gettitng there. I have a path to doing it, just need to work out some kinks
Node 4 had a syntax error????? SyntaxError: Unexpected token {
Probably destructuring
The failing tests are 'just' timeouts. :-\
@rwjblue squashed!
eslint check on node 7 timed out
restarted that one, but we should drop Node 7 in a followup PR
pods structure can now be migrated from.
This PR just adds to the existing code. I think a future PR should be a refactor. Lots of things need to be extracted to methods for easier inheritance.