search

ember-codemods / ember-module-migrator

Automated migration for new Ember application layout.
74 stars 15 forks source link

Check for undefined _privateRenderableInvoker #58

Closed andyhot closed 7 years ago

mixonic commented 7 years ago

Is there a test case for this? If it fixes a bug it would be great to have a regression check.

andyhot commented 7 years ago

You're right to ask. There isn't one.

I'm not sure how this can be reproduced but it's possible to see it when running the migrator against travis (the logged Cannot read property destRelativePath of undefined are caused by this). I manually validated the fix by seeing that add-env-var-test.js and add-ssh-key-test.js end up in the correct place.

Notice that the base class (https://github.com/rwjblue/ember-module-migrator/blob/master/lib/models/file-info.js) does indeed do the check that is missing here.

I'm fine with keeping this open till we have a failing test (though i'll be very low on time for the next 10 days to dig further)

mixonic commented 7 years ago

A-ok! If anyone is watching this repo: Creating a test for this regression might make a good new contribution :-)